Add or fix scrubbing in several adapters #2700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpollack
requested review from
curiousepic,
deedeelavinder,
dtykocki and
nfarve
dtykocki
approved these changes
Jan 8, 2018
|
@dtykocki Hah, point. That's because I wasn't consistent about what existing adapter's tests I was stealing. I'll look for what's most common as-is and then move them all over to that before merging. |
Unit: 14 tests, 34 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 29 tests, 90 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Unit: 29 tests, 141 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 24 tests, 105 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Three remote tests fail, all involving what I believe are enhancements to how specified currency is handled. None are impacted by this change, and fixing them is beyond the scope of this change. Unit: 33 tests, 158 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 26 tests, 97 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 88.4615% passed
Unit: 5 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 16 tests, 48 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Unit: 21 tests, 60 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 30 tests, 77 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Five remote tests fail, two involving extended options for purchases, two on storing, and one on credits. None of these are impacted by this patch series, and fixing them is beyond the scope of this series. (The errors appears to be some sort of transient issue with their test card processing.) Unit: 48 tests, 206 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 27 tests, 91 assertions, 5 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 77.7778% passed
|
Okay, all unified on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.