Skip to content

Fixed issue with resize in mode='a' - #718

Merged
AbhinavTuli merged 2 commits into
masterfrom
fix/append_shape
Mar 26, 2021
Merged

Fixed issue with resize in mode='a'#718
AbhinavTuli merged 2 commits into
masterfrom
fix/append_shape

Conversation

@kristinagrig06

Copy link
Copy Markdown
Contributor

Convert dynamic tensor shape to tuple.

@github-actions

Copy link
Copy Markdown

Locust summary

Git references

Initial: 184c64d
Terminal: 58be93d

hub/store/dynamic_tensor.py
Changes:
hub/auto/infer.py
Changes:
  • Name: _find_root
    Type: function
    Changed lines: 3
    Total lines: 29

    @AbhinavTuli

    Copy link
    Copy Markdown
    Contributor

    @kristinagrig06 can we add a test for this?

    @codecov

    codecov Bot commented Mar 26, 2021

    Copy link
    Copy Markdown

    Codecov Report

    Merging #718 (18b45f8) into master (ff283a5) will not change coverage.
    The diff coverage is 100.00%.

    Impacted file tree graph

    @@           Coverage Diff           @@
    ##           master     #718   +/-   ##
    =======================================
      Coverage   89.26%   89.26%           
    =======================================
      Files          63       63           
      Lines        4380     4380           
    =======================================
      Hits         3910     3910           
      Misses        470      470           
    Impacted Files Coverage Δ
    hub/store/dynamic_tensor.py 88.77% <100.00%> (ø)

    Continue to review full report at Codecov.

    Legend - Click here to learn more
    Δ = absolute <relative> (impact), ø = not affected, ? = missing data
    Powered by Codecov. Last update ff283a5...18b45f8. Read the comment docs.

    @AbhinavTuli
    AbhinavTuli merged commit 06cab25 into master Mar 26, 2021
    @kristinagrig06
    kristinagrig06 deleted the fix/append_shape branch May 31, 2021 13:00
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants