Skip to content

setup formatting and linting configuration #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2024
Merged

setup formatting and linting configuration #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7649ef7
chore: add EditorConfig for consistent editor settings
ahmad-kashkoush Nov 8, 2024
3e48e6b
chore: configure Prettier for code formatting
ahmad-kashkoush Nov 8, 2024
4368231
chore: set up ESLint for code linting and quality
ahmad-kashkoush Nov 8, 2024
d782914
chore: add format & linting scripts
ahmad-kashkoush Nov 8, 2024
cec5df1
style: apply Prettier formatting to existing files
ahmad-kashkoush Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# EditorConfig is awesome: https://editorconfig.org
# Top-most EditorConfig file
root = true

# Generic settings for all files
[*]
# Indentation
indent_style = space
indent_size = 2

# Line endings
end_of_line = lf

# Character encoding
charset = utf-8

# Trim trailing whitespace
trim_trailing_whitespace = true

# Insert final newline at the end of each file
insert_final_newline = true

# Settings for JavaScript and JSX files
[*.{js,jsx}]
indent_size = 2

# Settings for JSON files
[*.json]
indent_style = space
indent_size = 2

# Settings for Markdown files
[*.md]
trim_trailing_whitespace = false

# Settings for YAML files
[*.yml]
indent_style = space
indent_size = 2
13 changes: 13 additions & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"extends": [
"eslint:recommended",
"plugin:react/recommended",
"prettier"
],
"plugins": [
"prettier"
],
"rules": {
"prettier/prettier": "error"
}
}
7 changes: 7 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Ignore all build and dependency folders
node_modules
build
dist

# Ignore specific files
package-lock.json
11 changes: 10 additions & 1 deletion .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
{}
{
"singleQuote": true,
"trailingComma": "es5",
"jsxSingleQuote": true,
"semi": true,
"tabWidth": 2,
"printWidth": 80,
"bracketSpacing": true,
"arrowParens": "always"
}
12 changes: 6 additions & 6 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import js from '@eslint/js'
import globals from 'globals'
import react from 'eslint-plugin-react'
import reactHooks from 'eslint-plugin-react-hooks'
import reactRefresh from 'eslint-plugin-react-refresh'
import js from '@eslint/js';
import globals from 'globals';
import react from 'eslint-plugin-react';
import reactHooks from 'eslint-plugin-react-hooks';
import reactRefresh from 'eslint-plugin-react-refresh';

export default [
{ ignores: ['dist'] },
Expand Down Expand Up @@ -35,4 +35,4 @@ export default [
],
},
},
]
];
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
Expand Down
112 changes: 112 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
"scripts": {
"dev": "vite",
"build": "vite build",
"format:lint": "npm run format && npm run lint:fix",
"format": "prettier --write .",
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"preview": "vite preview"
},
"dependencies": {
Expand All @@ -26,6 +29,8 @@
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.3.1",
"eslint": "^9.9.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-react": "^7.35.0",
"eslint-plugin-react-hooks": "^5.1.0-rc.0",
"eslint-plugin-react-refresh": "^0.4.9",
Expand Down
76 changes: 34 additions & 42 deletions src/components/Shared/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,48 +1,40 @@
import { Box, Container, Link, Typography } from '@mui/material';
import { Link as RouterLink } from "react-router-dom";
import { Link as RouterLink } from 'react-router-dom';
import { GitHub } from '@mui/icons-material';
const Footer = () => {
return (
<Box
py={4}
bgcolor="black"
color="white"
textAlign="center"
component="footer"
>
<Container maxWidth="md">
<Typography variant="h6" component="div" gutterBottom>
Connect with Us
</Typography>
<Box display="flex" justifyContent="center" alignItems="center" gap={4}>
{/* TODO: Add link to about-us page */}
<Link
underline="hover"
component={RouterLink}
to="/"
color="inherit"
>
About us
</Link>
<Link
underline="hover"
href="https://github.com/activecourses/Upwork-Clone-Front"
color="inherit"

>
<GitHub />
</Link>
</Box>
<Typography variant="body2" color="inherit" mt={2}>
© {new Date().getFullYear()}{" "}
<Link href="https://github.com/activecourses">
Active courses
</Link>
. All rights reserved.
</Typography>
</Container>
</Box>
)
}
py={4}
bgcolor='black'
color='white'
textAlign='center'
component='footer'
>
<Container maxWidth='md'>
<Typography variant='h6' component='div' gutterBottom>
Connect with Us
</Typography>
<Box display='flex' justifyContent='center' alignItems='center' gap={4}>
{/* TODO: Add link to about-us page */}
<Link underline='hover' component={RouterLink} to='/' color='inherit'>
About us
</Link>
<Link
underline='hover'
href='https://github.com/activecourses/Upwork-Clone-Front'
color='inherit'
>
<GitHub />
</Link>
</Box>
<Typography variant='body2' color='inherit' mt={2}>
© {new Date().getFullYear()}{' '}
<Link href='https://github.com/activecourses'>Active courses</Link>.
All rights reserved.
</Typography>
</Container>
</Box>
);
};

export default Footer
export default Footer;
Loading