Skip to content

Maxdur fix #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 13, 2019
Merged

Maxdur fix #512

merged 8 commits into from
Nov 13, 2019

Conversation

lisaSW
Copy link
Contributor

@lisaSW lisaSW commented Nov 11, 2019

Updates to errors in how max duration for specific local hosts was being recorded.

@lisaSW lisaSW requested a review from ethack November 11, 2019 02:05
@ethack ethack merged commit 1592c06 into master Nov 13, 2019
@ethack ethack deleted the maxdur-fix branch November 13, 2019 18:20
@carrohan carrohan requested review from carrohan and ethack November 14, 2019 00:09
carrohan
carrohan reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@carrohan carrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran a dataset through with and without rolling. Import didn't have any problems, and all modules looked good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethack ethack Awaiting requested review from ethack

1 more reviewer

@carrohan carrohan carrohan left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisaSW @ethack @carrohan