Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting #51

Merged
merged 1 commit into from
Aug 23, 2013
Merged

Add sorting #51

merged 1 commit into from
Aug 23, 2013

Conversation

elia
Copy link
Member

@elia elia commented Aug 22, 2013

Taken from @bartoszkopinski (original compare)

  • no-collection case
  • filtering for sorting
  • conflict with simple_form

fixes #42

- no-collection case
- filtering for sorting
- conflict with simple_form
self.class.columns_hash[name.to_s]
end


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartoszkopinski what kind of conflict is was generating with simpleform?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting ActionView::Template::Error: undefined method 'number?' for #<ActiveAdmin::Mongoid::Document::ColumnWrapper:0x0000000bfa4ca8>
for

= f.input :email, required: true, autofocus: true, hint: false, label: false, input_html: { placeholder: "Email" }

not sure what the reason was, so this is rather a quick fix.

@elia elia mentioned this pull request Aug 22, 2013
elia added a commit that referenced this pull request Aug 23, 2013
@elia elia merged commit aa057b5 into master Aug 23, 2013
@elia elia deleted the sorting branch August 23, 2013 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort not working on master
2 participants