Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rubocop #154

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Introduce rubocop #154

merged 3 commits into from
Feb 20, 2020

Conversation

grzegorz-jakubiak
Copy link
Collaborator

No description provided.

@grzegorz-jakubiak
Copy link
Collaborator Author

No idea why Lint CI errors out 🤔 I wanted to add bundle exec rubocop after tests to .travis.yml. I guess we've got Lint CI configured for every repository that includes .rubocop.yml. @deivid-rodriguez any ideas?

@deivid-rodriguez
Copy link
Member

@timoschilling added this service to all repos in the organization at some point, but I don't think he's maintaining it any longer so I believe it's fine to disable it / remove it.

@timoschilling
Copy link
Member

Remove it. It’s no longer maintained. GH actions killed the business model

@deivid-rodriguez
Copy link
Member

I removed it, I think the check should stop showing up in a bit.

@deivid-rodriguez
Copy link
Member

Thanks @timoschilling! 👍

@grzegorz-jakubiak
Copy link
Collaborator Author

@timoschilling and @deivid-rodriguez thanks guys! I added bundle exec rubocop to .travis.yml. All green now and ready for review.

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grzegorz-jakubiak grzegorz-jakubiak merged commit 71039f2 into master Feb 20, 2020
@grzegorz-jakubiak grzegorz-jakubiak deleted the feature/rubocop branch February 20, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants