Repository navigation
Release 3.0.1 - #28
Merged
Merged
Conversation
Co-Authored-By: Clanker
Co-Authored-By: Clanker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version to 3.0.1 and moves the changelog's Unreleased entry under 3.0.1.
Patch release: it ships one fix, #27.
Fixes
filter_parametersentries match exact keys instead of substrings, so host params such ascode_id,state_eqandorder[state]show up in logs again (filter_parameters symbols hide host params like code_id and state_eq #26, Anchor OIDC filter_parameters so host params like code_id and state_eq stay visible #27). Token keys (code_verifier,id_token,access_token,refresh_token) are filtered at any depth.code,state,session_stateandnonceare filtered only at the top level.Check before upgrading
Up to 3.0.0 the engine hid every param whose name contained
code,state,nonceor a token name, at any depth. After 3.0.1 these show in logs in plain text:invite_code,reset_code,verification_code;code,state,session_state,nonce, such asuser[code].Hosts must add any of these that carry secrets to their own
filter_parameters. The CHANGELOG spells this out with an example.This ships as a patch because the old filtering was a bug, not a documented contract.