gather parsed SQLs by file name #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjjian
reviewed
Nov 27, 2023
parser.go
Outdated
|
|
||
| // ParseXMLsWithFilePath is a parser for parse all query in several XML files to map[string][]string one by one; | ||
| // you can set `skipErrorQuery` true to ignore invalid query. | ||
| func ParseXMLsWithFilePath(dataFromFiles []XmlFiles, skipErrorQuery bool) (map[string] /*file path*/ []string /*sqls*/, error) { |
There was a problem hiding this comment.
建议返回结构化的SQL内容，方便后续扩展，例如要返回SQL在XML文件里的位置等其他信息
type sqlInfo struct{
sql string
filepath string
} return []SqlInfo
sjjian
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actiontech/sqle/issues/2054