chore(ci): update dependencies #891

mmorel-35 · 2021-08-23T09:56:01Z

Hi @luketomlinson ! I have updated the current dependencies with the help of dependabot. When you have a chance to take a look 😊!
It fixes the audit failure by the way.

brcrista · 2021-08-25T13:26:59Z

Hey @mmorel-35 -- thanks for opening the PR. I see there are lots of changes here:

Adding Dependabot config
Updating package versions
Changing TypeScript settings
Adding type annotations in the code

You can help us out and increase your chances of your PR getting merged if you scope down to one specific thing. It's ok to submit multiple PRs for separate issues.

Also, if you can give more context in the description on the problem you are solving, that will be much appreciated as well. Thanks!

mmorel-35 · 2021-08-25T14:03:12Z

Hi @brcrista , I'm going to start by focusing on dependencies updates then

Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-Authored-By: MOREL Matthieu <matthieu.morel@cnp.fr> Co-Authored-By: Matthieu MOREL <mmorel-35@users.noreply.github.com>

mmorel-35 · 2021-08-25T14:51:57Z

packages/github/__tests__/github.proxy.test.ts

@@ -17,7 +17,7 @@ describe('@actions/github', () => {
  beforeAll(async () => {
    // Start proxy server
    proxyServer = proxy()
-    await new Promise(resolve => {
+    await new Promise<void>(resolve => {


This is required by "typescript": "^4.3.5"

mmorel-35 · 2021-08-25T14:52:01Z

packages/github/__tests__/github.proxy.test.ts

@@ -32,7 +32,7 @@ describe('@actions/github', () => {

  afterAll(async () => {
    // Stop proxy server
-    await new Promise(resolve => {
+    await new Promise<void>(resolve => {


This is required by "typescript": "^4.3.5"

mmorel-35 · 2021-08-25T14:52:22Z

packages/artifact/src/internal/download-http-client.ts

@@ -302,7 +302,7 @@ export class DownloadHttpClient {
    destinationStream: fs.WriteStream,
    isGzip: boolean
  ): Promise<void> {
-    await new Promise((resolve, reject) => {
+    await new Promise<void>((resolve, reject) => {


This is required by "typescript": "^4.3.5"

mmorel-35 · 2021-08-25T14:53:02Z

packages/artifact/__tests__/upload.test.ts

@@ -454,12 +454,12 @@ describe('Upload Tests', () => {
     */
    jest
      .spyOn(HttpClient.prototype, 'patch')
-      .mockImplementation(async (requestdata, data) => {
+      .mockImplementation(async (requestUrl, data) => {


This is to use the same names as in patch function

mmorel-35 · 2021-08-25T14:53:10Z

packages/artifact/__tests__/upload.test.ts

@@ -385,7 +385,7 @@ describe('Upload Tests', () => {
     */
    jest
      .spyOn(HttpClient.prototype, 'post')
-      .mockImplementation(async (requestdata, data) => {
+      .mockImplementation(async (requestUrl, data) => {


This is to use the same names as in post function

mmorel-35 · 2021-08-25T14:53:29Z

packages/artifact/__tests__/upload.test.ts

@@ -371,8 +371,8 @@ describe('Upload Tests', () => {
   * Helpers used to setup mocking for the HttpClient
   */
  async function emptyMockReadBody(): Promise<string> {
-    return new Promise(resolve => {
-      resolve()
+    return new Promise<string>(resolve => {


This is required by "typescript": "^4.3.5"

mmorel-35 · 2021-08-25T14:53:34Z

packages/artifact/__tests__/retry.test.ts

@@ -65,8 +65,8 @@ beforeAll(async () => {
 * Helpers used to setup mocking for the HttpClient
 */
 async function emptyMockReadBody(): Promise<string> {
-  return new Promise(resolve => {
-    resolve()
+  return new Promise<string>(resolve => {


This is required by "typescript": "^4.3.5"

mmorel-35 · 2021-08-25T14:53:38Z

packages/artifact/__tests__/download.test.ts

@@ -238,8 +238,8 @@ describe('Download Tests', () => {
   * Helper used to setup mocking for the HttpClient
   */
  async function emptyMockReadBody(): Promise<string> {
-    return new Promise(resolve => {
-      resolve()
+    return new Promise<string>(resolve => {


This is required by "typescript": "^4.3.5"

mmorel-35 · 2021-08-25T14:54:13Z

.eslintrc.json

@@ -11,6 +11,7 @@
    "eslint-comments/no-use": "off",
    "github/no-then": "off",
    "import/no-namespace": "off",
+    "import/named": "off",


This is because of "@typescript-eslint/parser": "^4.29.3"

mmorel-35 · 2021-08-31T06:32:40Z

Hi @brcrista, this is ready for review, when you have the time :)

…actions/cache repo

mmorel-35 requested a review from a team as a code owner August 23, 2021 09:56

mmorel-35 requested a review from a team August 23, 2021 09:56

mmorel-35 marked this pull request as draft August 25, 2021 14:28

mmorel-35 commented Aug 25, 2021

View reviewed changes

mmorel-35 marked this pull request as ready for review August 25, 2021 14:54

mmorel-35 closed this Oct 23, 2021

lvpx added a commit that referenced this pull request Aug 13, 2022

Bump internal package @actions/cache version to fix #888 and #891 in …

d543359

…actions/cache repo

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): update dependencies #891

chore(ci): update dependencies #891

mmorel-35 commented Aug 23, 2021 •

edited

Loading

brcrista commented Aug 25, 2021

mmorel-35 commented Aug 25, 2021

mmorel-35 Aug 25, 2021

mmorel-35 Aug 25, 2021

mmorel-35 Aug 25, 2021

mmorel-35 Aug 25, 2021

mmorel-35 Aug 25, 2021

mmorel-35 Aug 25, 2021

mmorel-35 Aug 25, 2021

mmorel-35 Aug 25, 2021

mmorel-35 Aug 25, 2021 •

edited

Loading

mmorel-35 commented Aug 31, 2021

chore(ci): update dependencies #891

chore(ci): update dependencies #891

Conversation

mmorel-35 commented Aug 23, 2021 • edited Loading

brcrista commented Aug 25, 2021

mmorel-35 commented Aug 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmorel-35 Aug 25, 2021 • edited Loading

Choose a reason for hiding this comment

mmorel-35 commented Aug 31, 2021

mmorel-35 commented Aug 23, 2021 •

edited

Loading

mmorel-35 Aug 25, 2021 •

edited

Loading