New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IN PROGRESS: Features/core #4

Merged

jclem merged 38 commits into master from features/core

May 21, 2019

Member

bryanmacfarlane commented May 17, 2019

No description provided.

Danny McCormick and others added 8 commits

May 16, 2019 16:40


          Add Bryan's core code

5f66339


          Match core to spec (still work to do)

917c389


          starting on core

780a598


          Spec for tool config apis (#3)

* creating an initial branch for config apis spec

* Add package specs

* mkdirP should return promise

* Which should return a promise

* Respond to feedback

* export => exportVariable

* Respond to feedback on spec

* Remove code for now

* trailing space

* Clarify throwing


          spec update

d7423ef


          update inputs and variables

a97380e


          Add tests

a526749


          Merge branch 'features/core' of https://github.com/actions/toolkit in…

7c079ef

…to features/core

bryanmacfarlane commented

View reviewed changes

docs/package-specs.md Outdated Show resolved Hide resolved


          update specs

792122b

bryanmacfarlane commented

View reviewed changes

docs/package-specs.md Show resolved Hide resolved

bryanmacfarlane commented

View reviewed changes

docs/package-specs.md Show resolved Hide resolved

Danny McCormick and others added 3 commits

May 17, 2019 10:31


          Add tests, getInput should be case-insensitive and trim output

5f31b6a


          Merge branch 'features/core' of https://github.com/actions/toolkit in…

aa10eec

…to features/core


          spec update

2e72908

damccorm reviewed

View reviewed changes

packages/core/src/core.ts Outdated Show resolved Hide resolved

damccorm reviewed

View reviewed changes

packages/core/src/internal.ts Outdated Show resolved Hide resolved

damccorm reviewed

View reviewed changes

packages/core/src/internal.ts Outdated Show resolved Hide resolved

damccorm reviewed

View reviewed changes

packages/core/src/internal.ts Outdated Show resolved Hide resolved

damccorm reviewed

View reviewed changes

packages/core/src/core.ts Outdated Show resolved Hide resolved

Danny McCormick and others added 10 commits

May 17, 2019 14:12


          Finish test suite

e6cc6dc


          Run linter

97c1e7d


          Fix formatter to check all TypeScript

0f12556


          Format lib.test.ts

3ca5804


          Add .prettierignore

70a281f


          Merge branch 'master' into features/core

3bb3f36


          Merge branch 'master' into features/core

4090b77


          Run npm run lint -- --fix

451bb07


          Fix ESLint errors

978b6e0


          Add links to code in package READMEs

c999afb

Intsead of having to update the READMEs for each package whenever
TypeScript signatures change, link directly to the TypeScript code.
Later, we can run a Typedoc server, perhaps.

jclem added 9 commits

May 21, 2019 11:07


          Fix .tsx typo

f5d5c79


          'use strict' not necessary in TypeScript

4439c53


          DRY up core tests

a52644e


          Use ES imports

90008fc


          Use ExitCode from @actions/exit

062a6bb


          Fix namespace use in core.ts

c3ed3b1


          Remove environment variables after we set them

11d5a53


          Use a Jest mock to test process.stdout.write

Instead of manually mocking, we can instead use `jest.fn()` and assert that the correct calls were made.


          DRY up asserts on process.stdout.write

f30996e

jclem suggested changes

View reviewed changes

Contributor

jclem left a comment

Awesome work getting this moved in! Thank you.

I've made a few changes on my own, and then left a few comments about changes I think we should make. Let me know if you agree!

packages/core/src/interfaces.ts Outdated Show resolved Hide resolved

packages/core/src/internal.ts Outdated Show resolved Hide resolved

packages/core/src/internal.ts Outdated Show resolved Hide resolved

packages/core/src/core.ts Show resolved Hide resolved

packages/core/__tests__/lib.test.ts Show resolved Hide resolved

packages/core/src/core.ts Outdated Show resolved Hide resolved

packages/core/src/internal.ts Outdated Show resolved Hide resolved

packages/core/src/internal.ts Outdated Show resolved Hide resolved

Danny McCormick added 4 commits

May 21, 2019 14:38


          Clean up/respond to feedback

ea0dd28


          set-env instead of set-variable

b25c877


          Add internal disclaimer in command.ts

6bd1190


          Run formatter

140d6cd

Contributor

damccorm commented May 21, 2019

@jclem responded to all your feedback - everything you mentioned made sense, updated appropriately.

jclem added 3 commits

May 21, 2019 15:23


          Remove "public" explicit accessibility

8cdf51d


          Rename escapedata to escapeData

ab9b8a0


          Rename command import in core.ts

b057387

jclem approved these changes

View reviewed changes

jclem merged commit 026ad6f into master

jclem deleted the features/core branch

May 21, 2019 19:29

samuelmonday699 reviewed

View reviewed changes

samuelmonday699 left a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet