fix print outputs step in existing workflows #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irega
changed the title
Closed
|
@luketomlinson @rentziass @flaxel @JoannaaKL could you take a look at this PR? 🙏 |
flaxel
approved these changes
Oct 26, 2022
|
@luketomlinson @rentziass @JoannaaKL friendly ping 😄 I think I need one more approval to merge |
|
@luketomlinson @rentziass @JoannaaKL friendly ping. |
1 similar comment
|
@luketomlinson @rentziass @JoannaaKL friendly ping. |
|
@luketomlinson @rentziass @JoannaaKL @pje @marko-zivic-93 @e-korolevskii friendly ping. |
Thank you @e-korolevskii! it seems I don't have the required permissions to merge the PR, who could do it? cc @luketomlinson @rentziass @JoannaaKL @pje @marko-zivic-93 |
JoannaaKL
approved these changes
Dec 13, 2022
davorpa
added a commit
to davorpa/free-programming-books
that referenced
this pull request
Feb 22, 2023
2 tasks
eshellman
pushed a commit
to EbookFoundation/free-programming-books
that referenced
this pull request
Feb 23, 2023
…9287) * security: `set-output` cmd deprecated. Use `$GITHUB_OUTPUT` env file To avoid untrusted logged data to use `save-state` and `set-output` workflow commands without the intention of the workflow author we have introduced a new set of environment files to manage state and output. Starting 1st June 2023 workflows using `save-state` or `set-output` commands via stdout will fail with an error. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ * chore: apply fix found at actions/stale#859 * test: fixing report escapes * test: fixing report escapes * test: fixing report escapes * test: fixing report escapes * test: fixing report escapes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Print outputswhich is causing the current workflows failing.Context
The current workflows are failing in the repo, they are stuck in the
Print outputsstep. After debugging them using act, I realized the outputs were printed wrong, repeating all the properties from each array element over and over again, such as:The error is more notorious now and causes the workflows failing due to we have more staled/closed issues and pull requests in the repo.
Using the toJSON expression to get a pretty-print JSON representation for each output fixes the problem.