feat: bump to use node20 runtime, actions/checkout to v4#846
Closed
kbdharun wants to merge 2 commits intoactions:mainfrom
Closed
feat: bump to use node20 runtime, actions/checkout to v4#846kbdharun wants to merge 2 commits intoactions:mainfrom
kbdharun wants to merge 2 commits intoactions:mainfrom
Conversation
Contributor
|
Hello @kbdharun. Thank you for your pull request. Could you please revert changes in |
|
Any update on this? |
|
Just curious, why the docs needed a revert, if one of this PR's points is to bump
|
nikolai-laevskii
approved these changes
Nov 10, 2023
Author
|
This seems to be superseded and completed in #866. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Node20 was added to Actions Runner on v2.308.0 and Node16 reaches end of life soon on 11 Sep 2023.
Therefore, This PR updates the default runtime to node20. I have bumped the actions/checkout version to v4 for the same.
Related issue:
actions/runner#2732
Check list:
A major version bump might be needed after the PRs merge.