Add ability to use package json version.#469
Add ability to use package json version.#469The-Code-Monkey wants to merge 1 commit intoactions:mainfrom The-Code-Monkey:patch-1
Conversation
This will only work with top level package json file and not nested files.
| const packageJson = JSON.parse( | ||
| fs.readFileSync( | ||
| path.join( | ||
| process.env.GITHUB_WORKSPACE!, |
There was a problem hiding this comment.
| process.env.GITHUB_WORKSPACE!, | |
| process.env.GITHUB_WORKSPACE, |
I think we should use node-version-file or similar here to support package.json in subdirectory.
Besides, is the version definition format in package.json (it includes eg. version ranges) the same as expected here or we have to resolve it?
There was a problem hiding this comment.
The idea behind this is for people who have a fixed node version. So doesn't need to interpret anything other than the value. Also I copied the code from above in the file so don't think it requires changing
|
Hi, @The-Code-Monkey, Unfortunately checks were not successful. First of all you need to manually run build and add the results to the PR. Cheers. |
|
Ok no worries I've not had much time to get back to the pr and fix it been busy with work |
|
Hi @The-Code-Monkey, Just a gentle ping. |
|
This is addressing the same issue as #485, correct? Seems like that one is farther along, so let's go with that one. |
4 participants
This will only work with top level package json file and not nested files.
Description:
Adds the ability to specify "package" as node version instead of a number
Related issue:
#467
Check list: