-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pnpm caching support #278
Conversation
Hey @jacobwgillespie , thank you for your contribution, Your changes look awesome! Did you have a chance to validate it on any real project? You can reference your fork branch via |
@maxim-lobanov no problem, take your time, and let me know if there's anything I can do to help as you're reviewing! I did validate it on some internal projects - if you'd like a public example, I just updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. I have left minor comment to add additional validation.
I will ping more engineers to review it from our side and also we will do basic validation from our side.
Co-authored-by: Konrad Pabjan <konradpabjan@github.com>
@bryanmacfarlane , could you please review and approve this PR when you have a chance? If you don't have objections - we can release new action version next week with these changes. |
Hello @jacobwgillespie , just an update. We will be ready to cut new action release at the begin of next week. |
Awesome! 🎉 Thank you so much, excited to see this released! |
Hello @jacobwgillespie! Would you like to create a PR in the github/docs repository to update GitHub Docs in accordance with your changes? |
@MaksimZhukov perfect, thanks for the merge and release! I've created a docs PR here: github/docs#8389 |
Bumps [husky](https://github.com/typicode/husky) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR extends the excellent caching work at #272 with support for pnpm.
The global module store is stored at
~/.pnpm-store
by default, unless otherwise configured.pnpm get store
returns the custom store path, or the stringundefined
if no custom store is configured, so this PR adds adefaultCacheFolder
option that is used as a fallback if thegetCacheFolderCommand
does not return a path. Note that the cache directory path is sent ultimately to@actions/glob
, and that module handles the expansion of~/
to the current home directory, so it's okay that the path is not expanded here.Note: I've opened a PR on
pnpm/pnpm
to add a new command that returns the current module store directory, including the default if no custom path is set, but even if that PR is accepted, I believe we'd still need to support thedefaultCacheFolder
fallback here as current and past versions of pnpm would not support the new command.I've added tests and Actions workflow jobs to match the existing npm and yarn 1 / 2 tests.