Consolidate duplicate jobs in e2e-versions workflow#1125
Merged
Conversation
Merge the three EA jobs (zulu, temurin, sapmachine) into a single setup-java-ea-versions job driven by a matrix include list, and merge the two signature-verification jobs (temurin, microsoft) into a single setup-java-signature-verification job with a distribution matrix dimension. Test coverage is unchanged: all 15 EA combos and all 12 signature combos still run. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9924b163-0ad2-4f8c-b038-0f00220a3157
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the .github/workflows/e2e-versions.yml GitHub Actions workflow to reduce duplicated job definitions by consolidating equivalent jobs into matrix-driven jobs, while keeping the same distribution × version × OS execution coverage.
Changes:
- Consolidates the three EA-version jobs into a single
setup-java-ea-versionsjob using a purematrix.includelist to preserve per-distribution runner differences. - Consolidates the two signature-verification jobs into a single
setup-java-signature-verificationjob by adding adistribution: [temurin, microsoft]matrix dimension.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/e2e-versions.yml | Consolidates duplicated EA and signature-verification jobs using matrix strategies while preserving existing execution combinations. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consolidates duplicate jobs in
.github/workflows/e2e-versions.ymlusing matrixinclude, with zero change to test coverage — every distribution × version × OS combination that runs today still runs.Merges
Early-access (EA) jobs →
setup-java-ea-versionssetup-java-ea-versions-zulu,setup-java-ea-versions-temurin, andsetup-java-ea-versions-sapmachine.macos-15-intel, the others usemacos-latest), the matrix is built entirely from aninclude:list — one entry per os × version × distribution combo, with no base matrix keys.Signature-verification jobs →
setup-java-signature-verificationsetup-java-temurin-signature-verificationandsetup-java-microsoft-signature-verification.distribution: [temurin, microsoft]matrix dimension over os {macos-latest, windows-latest, ubuntu-latest} × version {21, 17} (12 combos).Coverage
Unchanged. Combination counts verified:
No other jobs were touched;
check-latestandmultiple-jdksare unchanged. YAML validated withyaml.safe_load.