Use explicit filename when downloading Windows go package#250
Merged
marko-zivic-93 merged 1 commit intoactions:mainfrom Aug 4, 2022
Merged
Conversation
Using the explicit filename for Windows is necessary to satisfy `Expand-Archive`'s requirement on '.zip' extension. Signed-off-by: Javier Romero <root@jromero.codes>
dmitry-shibanov
approved these changes
Jul 29, 2022
marko-zivic-93
approved these changes
Aug 1, 2022
panticmilos
approved these changes
Aug 1, 2022
Contributor
Author
|
@dmitry-shibanov / @marko-zivic-93 Any insight as to when this may be merged and/or released? |
|
I just saw this after updating a job to use 1.19 on a shared runner - any chance we can get a v3.2.2 released? |
Contributor
|
Hi @milas, we will get release for this today or tomorrow :) |
Contributor
|
Hi guys, just to update you, the release will be at the start of the next week instead. We were waiting for one more feature to include in the release. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Use explicit filename when downloading Windows go package.
Using the explicit filename for Windows is necessary to satisfy
Expand-Archive's requirement on.zipextension.The solution can be seen working here (screenshot).
Credit goes to @redanthrax for finding the root cause.
This PR differs from #242 in the following ways:
RUNNER_TEMPenv var similar to tool-cache.tool-cachelibrary (to minimize changes).Related issue:
Fixes #241
Check list: