This repository has been archived by the owner on Jan 20, 2021. It is now read-only.
Adds exact installed versions of Elixir and OTP as outputs #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea. I'm out of office until mid-week and will take a look once I'm back. |
|
Hi, sorry to bug; any chance we can get this looked at soon? Thanks! 😄 |
|
This is a great contribution. Thank you, @doughsay! I'm going to remove the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the exact matched Elixir and OTP versions as outputs of the step. This allows subsequent steps to know which versions were installed if ranges were specified. e.g. specifying input
elixir-versionas "1.10.x" will add an output calledelixir-versionwith the value "v1.10.4".This could be useful for certain use-cases like cache busting. Using the OTP version in your cache key for example will help with not re-using caches for old OTP version, which can sometimes cause compilation problems.
I did a fresh checkout of this repo using nodejs v14.6.0, and just running
yarncaused the lockfile to change a lot. I'm not really sure what's going on with that, this was an unintended consequence. Similarly, the compileddist/index.jshas a lot more changes in it than I expected as well... also not sure what's going on there. If someone could guide me in cleaning this PR up I would appreciate it!