Generate SHA's for released packages and include them in package notes #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
commented
Jan 27, 2021
| - run: | | ||
| file=$(ls) | ||
| sha=$(sha256sum $file | awk '{ print $1 }') | ||
| echo "Computed sha256: $sha for $file" |
There was a problem hiding this comment.
helpful for debugging and lets us ensure the sha gets into the build log.
TingluoHuang
approved these changes
Jan 27, 2021
ericsciple
reviewed
Jan 27, 2021
| @@ -45,6 +45,12 @@ jobs: | |||
|
|
|||
| build: | |||
| needs: check | |||
| outputs: | |||
| linux-x64-sha: ${{ steps.sha.outputs.linux-x64-sha256 }} | |||
There was a problem hiding this comment.
curious whether ${{ matrix.runtime }}-sha: ${{ steps.compute-sha.outputs.sha }} would work?
There was a problem hiding this comment.
ok to be explicit too... looks like there is another place below where we have to repeat the runtimes, so whatevs :)
There was a problem hiding this comment.
other way around repeating platforms in multiple places might be to upload as part of artifact
TingluoHuang
pushed a commit
that referenced
this pull request
Apr 21, 2021
#948) * Update release.yml Compute Sha's for release builds * Update release notes with shas * Update releaseNote.md * Update release.yml * Update release.yml * Update release.yml * Add Ability to Get Sha's * fix typo * remove debug code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the release process to include sha256 hashes of the runner downloads. Users can use these to verify that they have downloaded the correct runner and it has not been tampered with.
Example (fake) runner release is found here