Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify on unsecure commands #731

Merged
merged 11 commits into from
Oct 2, 2020
Merged

Notify on unsecure commands #731

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1738c7d
notify on unsecure commands
thboop Oct 1, 2020
944c9e7
notify on unsecure commands
thboop Oct 1, 2020
bab52e2
Correct text
thboop Oct 1, 2020
de01119
better messaging
thboop Oct 1, 2020
f242b50
make generic opt into unsecure commands
thboop Oct 1, 2020
7933f1a
Respond to Julio's feedback!
thboop Oct 1, 2020
947680d
slight verbiage update
thboop Oct 1, 2020
91ebfe7
Pr feedback
thboop Oct 2, 2020
204d934
swap to env context to get step level variables
thboop Oct 2, 2020
072047b
re-add runner check
thboop Oct 2, 2020
daafd3a
verbiage update
thboop Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
slight verbiage update
  • Loading branch information
@thboop
thboop committed Oct 1, 2020
commit 947680d4221bb4ffbc952e14df9cff981ab4cd62
2 changes: 1 addition & 1 deletion src/Runner.Common/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public static class ReturnCode
public static readonly string WorkerCrash = "WORKER_CRASH";
public static readonly string UnsupportedCommand = "UNSUPPORTED_COMMAND";
public static readonly string UnsupportedCommandMessage = "The `{0}` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/";
public static readonly string UnsupportedCommandMessageDisabled = "The `{0}` command is disabled. Please upgrade to using Environment Files or to opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable on the Runner to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/";
public static readonly string UnsupportedCommandMessageDisabled = "The `{0}` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable on the Runner to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/";
}

public static class RunnerEvent
Expand Down