Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log runner group name #696

Merged
merged 2 commits into from
Oct 16, 2020
Merged

log runner group name #696

merged 2 commits into from
Oct 16, 2020

Conversation

hfaulds
Copy link
Contributor

@hfaulds hfaulds commented Sep 8, 2020

This PR logs the runner group name in the Set up job step.

This variable isn't being sent yet but this PR should work fine without it (it'll have no affect) and then once it starts getting sent it'll start being logged.

@hfaulds hfaulds requested a review from lokesh755 September 8, 2020 10:36
@hfaulds hfaulds force-pushed the hfaulds/runner-group-name branch from bfd1b1a to d7f977e Compare September 9, 2020 14:33
@hfaulds
Copy link
Contributor Author

hfaulds commented Oct 16, 2020

I tested this. For organizations and enterprises it works great. For repository runners it always logs Default as the runner group name. I confirmed this is acceptable so am merging.

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hfaulds hfaulds merged commit 2e3b036 into main Oct 16, 2020
@hfaulds hfaulds deleted the hfaulds/runner-group-name branch October 16, 2020 13:56
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jan 28, 2021
* log runner group name

* linting
TingluoHuang pushed a commit that referenced this pull request Apr 21, 2021
* log runner group name

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants