cache actions on premises and download from .com #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Mar 22, 2020
ericsciple
commented
Mar 22, 2020
ericsciple
commented
Mar 23, 2020
ericsciple
commented
Mar 23, 2020
|
We might need to also not supply the token in this case. Not sure. We know that not having a token from dotcom will rate limit us (anonymous). However, if we supply the wrong token (the one from ghes), the first request might fail. |
ericsciple
changed the title
ericsciple
commented
Mar 24, 2020
ericsciple
force-pushed
the
users/ericsciple/m168cache
branch
from
add9e7d to
31b8628
Compare
ericsciple
commented
Mar 24, 2020
| if (!string.IsNullOrEmpty(authToken)) | ||
| var configurationStore = HostContext.GetService<IConfigurationStore>(); | ||
| var isHostedServer = configurationStore.GetSettings().IsHostedServer; | ||
| if (isHostedServer) |
There was a problem hiding this comment.
the diff looks bad, but adding auth header just moved inside if block
ericsciple
changed the title
TingluoHuang
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables downloading actions for GHES alpha. The goal is
actions/checkoutworks in GHES alpha.For alpha only, the following changes
For beta, a different solution will be used (actions shipped in box).