commands translate file path from container action #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Feb 12, 2020
ericsciple
commented
Feb 12, 2020
| @@ -1,6 +1,7 @@ | |||
| using GitHub.DistributedTask.Pipelines; | |||
| using GitHub.DistributedTask.WebApi; | |||
| using GitHub.Runner.Common.Util; | |||
| using GitHub.Runner.Worker.Container; | |||
There was a problem hiding this comment.
despite the diff, the actual change is pretty small. The diff looks bad due to the signature change of IActionCommandExtension.ProcessCommand()
ericsciple
commented
Feb 12, 2020
| @@ -84,7 +84,7 @@ public void OnDataReceived(object sender, ProcessDataReceivedEventArgs e) | |||
| { | |||
| // This does not need to be inside of a critical section. | |||
| // The logging queues and command handlers are thread-safe. | |||
| if (_commandManager.TryProcessCommand(_executionContext, line)) | |||
| if (_commandManager.TryProcessCommand(_executionContext, line, _container)) | |||
There was a problem hiding this comment.
OutputManager is the only place that calls commandManager.TryProcessCommand
In the OutputManager ctor, _container is set to "step container ?? job container".
The change here is to pass the correct container for the command manager to use when translating paths.
TingluoHuang
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.