Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SelfUpdate Flow when Package is provided in Message #2926

Merged
merged 34 commits into from
Nov 13, 2023
Merged

Handle SelfUpdate Flow when Package is provided in Message #2926

merged 34 commits into from
Nov 13, 2023

Conversation

luketomlinson
Copy link
Contributor

@luketomlinson luketomlinson commented Oct 13, 2023 •
edited
Loading

We want to be able to support the scenario where the the Runner can handle a package when it is received in the message payload. This allows updates without having to reach out to the PackageService.

Screenshot 2023-11-01 at 5 49 35 PM

@luketomlinson luketomlinson changed the title New update flow Handle SelfUpdate Flow when Package is provided in Message Oct 13, 2023
@luketomlinson luketomlinson marked this pull request as ready for review October 13, 2023 19:01
@luketomlinson luketomlinson requested a review from a team as a code owner October 13, 2023 19:01
sethrylan
sethrylan reviewed Oct 16, 2023
View reviewed changes
src/Runner.Listener/Runner.cs Outdated Show resolved Hide resolved
src/Runner.Listener/SelfUpdaterV2.cs Outdated Show resolved Hide resolved
src/Runner.Listener/SelfUpdaterV2.cs Show resolved Hide resolved
rentziass
rentziass previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@rentziass rentziass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luketomlinson luketomlinson merged commit a9bae6f into main Nov 13, 2023
10 checks passed
@luketomlinson luketomlinson deleted the new-update-flow branch November 13, 2023 21:44
@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrylan sethrylan sethrylan left review comments

@bryanmacfarlane bryanmacfarlane bryanmacfarlane left review comments

@TingluoHuang TingluoHuang TingluoHuang approved these changes

@rentziass rentziass rentziass left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luketomlinson @bryanmacfarlane @TingluoHuang @sethrylan @rentziass