Initialize container manager based on whether the ContainerHooksPath is set #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
reviewed
Dec 16, 2022
| @@ -111,7 +151,6 @@ private void Setup([CallerMemberName] string testName = "") | |||
| _containerHookManager = new Mock<IContainerHookManager>(); | |||
| containerOperationProvider = new ContainerOperationProvider(); | |||
|
|
|||
| _hc.SetSingleton<IDockerCommandManager>(_dockerManager.Object); | |||
There was a problem hiding this comment.
Do you know why this was set in the first place if never used?
There was a problem hiding this comment.
No, but I saw another set below which is exactly the same, so it should not influence the execution, right?
Tests are passing and setup is used for them so I guess this is okay
fhammerl
reviewed
Dec 16, 2022
nikola-jokic
added a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
…is set (actions#2317) * Added tests around checking if correct manager's Initialize method has been called * repaired missing initialization on container action handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the operation provider is called, it initializes both the dockerManager and the containerHookManager.
The dockerManager will call
whichon docker, which can cause initialization to fail.The fix should relax the docker cli dependency if the runner is going to use container hooks.
Related to the issue in runner-container-hooks: actions/runner-container-hooks#30