Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull upstream #2178

Merged
merged 22 commits into from
Oct 5, 2022
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
01fd044
Escaping key and quoting it to avoid key based command injection (#2062)
nikola-jokic Aug 23, 2022
cba19c4
Release notes for 2.296.0 (#2078)
AvaStancu Aug 23, 2022
5989479
Validate lines and columns for Annotations (#2082)
konradpabjan Aug 24, 2022
95459de
docker: escape key-value pair as -e KEY and VALUE being environment v…
nikola-jokic Aug 31, 2022
5e0c2ef
2.296.1 Release (#2092) (#2099)
fhammerl Sep 2, 2022
7578675
fix ACTIONS_RUNNER_CONTAINER_HOOKS name in ADR (#2098)
nikola-jokic Sep 6, 2022
ed191b7
Port hotfix to main branch (#2108)
thboop Sep 9, 2022
6e6410d
fix for issue #2009 - composite summary file (#2077)
ruvceskistefan Sep 12, 2022
32845a5
Bump @actions/core from 1.2.6 to 1.9.1 in /src/Misc/expressionFunc/ha…
rentziass Sep 15, 2022
6cdd272
Remove unused imports (#2124)
JoannaaKL Sep 15, 2022
3a1c897
Remove unused imports (#2126)
JoannaaKL Sep 15, 2022
0678e8d
Add Release branches to pull request spec (#2134)
thboop Sep 19, 2022
15cbadb
Add file commands for save-state and set-output (#2118)
rentziass Sep 26, 2022
ae2f4a6
POC: Windows arm64 runner build (#2022)
thboop Sep 26, 2022
bc67f99
Add link to blog post to node 12 warn (#2156)
takost Sep 26, 2022
01ff38f
2.297.0 release notes (#2155)
thboop Sep 26, 2022
dca4f67
Adding a new vars context for non-secret variables (#2096)
tauhid621 Sep 30, 2022
9492691
Avastancu/joannaakl/service container error log (#2110)
JoannaaKL Oct 3, 2022
920fba9
Add warning for users using deprecated commands (#2164)
rentziass Oct 4, 2022
4935be5
Prepare release notes for v2.298.0 (#2169)
rentziass Oct 4, 2022
1379ed2
Fix incorrect template vars to show SHA for WIN-ARM64 (#2171)
fhammerl Oct 4, 2022
86d0ee8
Backport 2.298.1 (#2175)
fhammerl Oct 4, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix ACTIONS_RUNNER_CONTAINER_HOOKS name in ADR (#2098)
  • Loading branch information
nikola-jokic authored Sep 6, 2022
commit 75786756bbe951b2a1ee3ca9e506888e61af7428
2 changes: 1 addition & 1 deletion docs/adrs/1891-container-hooks.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ We should give them that option, and publish examples how how they can create th
- For example, the current runner overrides `HOME`, we can do that in the hook, but we shouldn't pass that hook as an ENV with the other env's the user has set, as that is not user input, it is how the runner invokes containers

## Interface
- You will set the variable `ACTIONS_RUNNER_CONTAINER_HOOK=/Users/foo/runner/hooks.js` which is the entrypoint to your hook handler.
- You will set the variable `ACTIONS_RUNNER_CONTAINER_HOOKS=/Users/foo/runner/hooks.js` which is the entrypoint to your hook handler.
- There is no partial opt in, you must handle every hook
- We will pass a command and some args via `stdin`
- An exit code of 0 is a success, every other exit code is a failure
Expand Down