Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PrependPath format to be array instead of a concatenated string #1948

Merged
merged 237 commits into from
Jun 22, 2022
Merged

Fix PrependPath format to be array instead of a concatenated string #1948

merged 237 commits into from
Jun 22, 2022

Conversation

fhammerl
Copy link
Contributor

@fhammerl fhammerl commented Jun 16, 2022 •
edited
Loading

... to match the format specified in the ADR.
Sorry about commit history, I will merge with auto-merge (squash).

Nikola Jokic and others added 30 commits March 9, 2022 13:18
Added ability to run Dockerfile.SUFFIX ContainerAction
8142f10
Extracted IsDockerFile method
ec56106
reformatted, moved from index to Last()
c4e0443
extracted IsDockerfile to DockerUtil with L0
f98b197
added check for IsDockerfile to account for docker://
5f0c2f7
updated test to clearly show path/dockerfile:tag
735f6cb
fail if Data.Image is not Dockerfile or docker://[image]
c560265
@fhammerl
Setup noops for JobPrepare and JobCleanup hooks
821e4e2
@fhammerl
Add container jobstarted and jobcomplete hooks
6be2337
@fhammerl
Run 'index.js' instead of specific command hooks
f35602e
@fhammerl
Call jobprepare with command arg
a322d9d
@fhammerl @nikola-jokic
Use right command name (hardcoded)
25c6115 
Co-authored-by: Nikola Jokic <nikola-jokic@users.noreply.github.com>
@fhammerl
Invoke hooks with arguments
002caa1
@fhammerl @nikola-jokic
Add PrepareJob hook to work with jobcontainers
394aeed 
Co-authored-by: Nikola Jokic <nikola-jokic@users.noreply.github.com>
@fhammerl
Rename methods
b325643
@fhammerl
Use new hookcontainer to run prep and clean hooks
7a1e051
@fhammerl
Get path from ENV
76a82b0
@fhammerl
Use enums
7739cb4
@fhammerl
Use IOUtils.cs
5faa74b
@fhammerl
Move container files to folder
547e08e
@fhammerl
Move namespaces
0786cdf
@fhammerl
Store "state" between hooks
75a910f
@fhammerl
Remove stdin stream in containerstephosts
ef3c45e
@fhammerl
Update Constants.cs
6268924
@fhammerl
Throw if stdin fails
7c0bd75
@fhammerl
Cleanup obvious nullrefs and unused vars
f5ddd03
@fhammerl
Cleanup containerhook directory
ee13ad8
@fhammerl
Call step exec hook
7ad6db3
@fhammerl
Fix windows build
a8e4810
@fhammerl
Remove hook from hookContainer
73c1afe
fhammerl and others added 21 commits June 9, 2022 06:14
@fhammerl
Allow jobs without jobContainer to run
2cf7675
@fhammerl
Use JObject instead of JToken
8153781
@fhammerl
Use correct Response type
951fb31
@fhammerl
Format class to move cleanupJobAsync to the end of public methods
dca2296
@fhammerl
Rename HookIndexPath to HookScriptPath
2de2a1c
@fhammerl
Refactor methods into expression bodies
b82c191
@fhammerl
Fix args class hierarchy
bc2fd10
@fhammerl
Fix argument order
d0f699a
@fhammerl
Formatting
15e190f
@fhammerl
Fix nullref and don't swallow stacktrace
540dc59
@fhammerl
Whilelist HookArgs
de835c3
@fhammerl
Use FF in FeatureManager
503f76a
@fhammerl @TingluoHuang
Update src/Runner.Worker/ContainerOperationProvider.cs
e400372 
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
@fhammerl @thboop
Update src/Runner.Worker/ActionRunner.cs
7a8e404 
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
@fhammerl @thboop
Update src/Runner.Worker/ActionRunner.cs
3bc3023 
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
@fhammerl
Only mount well known dirs to job containers
e86f610
@fhammerl
Get trace from hostcontext
dfd73ad
@fhammerl
Use hook execution for setting telemetry
6b28c25
@fhammerl
Merge branch 'main' of https://github.com/actions/runner into main
2c7d6ca
@fhammerl
Merge branch 'main' of https://github.com/actions/runner into main
8ab25c8
@fhammerl
Fix prependPath format
5975e2e
@fhammerl fhammerl requested a review from a team as a code owner June 16, 2022 13:08
@fhammerl fhammerl changed the title Fhammerl/fix prependpath format Fix PrependPath format to be array instead of a concatenated string Jun 16, 2022
@fhammerl fhammerl enabled auto-merge (squash) June 16, 2022 13:08
@fhammerl fhammerl disabled auto-merge June 16, 2022 13:09
thboop
thboop approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop thboop merged commit 416771d into main Jun 22, 2022
@thboop thboop deleted the fhammerl/fix-prependpath-format branch June 22, 2022 13:11
@Thaonhi1998
Copy link

... to match the format specified in the ADR.
Sorry about commit history, I will merge with auto-merge (squash).

@Thaonhi1998 Thaonhi1998 mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thboop thboop thboop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fhammerl @Thaonhi1998 @thboop @nikola-jokic @ruvceskistefan