Added to lower on action_status to be consistent with the job.status #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
LGTM
No change in behaviour ( checks like {{ github.action_status == 'Failure'}} were already equivalent {{ github.action_status == 'failure'}}
But printing with echo ${{ github.action_status }} will now print 'success' or 'failure', consistent with job status (github.status)
ChristopherHX
pushed a commit
to ChristopherHX/runner.server
that referenced
this pull request
Nov 24, 2022
7 tasks
nikola-jokic
added a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we echo
job.status, it will outputfailure.But if we run echo
github.action_statusin a composite action, it would echoFailure.This PR is just for consistency.
Fixes #1841