Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed throw and else on container action handler #1873

Merged
merged 11 commits into from
Jun 17, 2023
Merged

removed throw and else on container action handler #1873

merged 11 commits into from
Jun 17, 2023

Conversation

nikola-jokic
Copy link
Contributor

No description provided.

@nikola-jokic nikola-jokic requested a review from a team as a code owner May 4, 2022 13:33
@TingluoHuang
Copy link
Member

Any linked issue for the fix?

@nikola-jokic
Copy link
Contributor Author

This is the original PR https://github.com/actions/runner/pull/1738/files
This was reverted because the else statement should not exist in ContainerActionHandler.cs

fhammerl
fhammerl previously approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhammerl fhammerl enabled auto-merge (squash) June 2, 2023 11:09
@fhammerl
Copy link
Contributor

fhammerl commented Jun 2, 2023

Release Notes: Fixed a bug where in a container action, image values like e.g. dockerfile.foo.bar or example/Dockerfile.test are treated as existing docker images in the registry instead of the filenames they likely are.

@nikola-jokic @TingluoHuang
Update src/Runner.Worker/Container/DockerUtil.cs
ae9984a 
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
@fhammerl fhammerl merged commit 8415f13 into actions:main Jun 17, 2023
@nikola-jokic nikola-jokic deleted the nikola-jokic/docker-suffix/1416 branch June 17, 2023 06:44
ashb pushed a commit to ashb/runner that referenced this pull request Jun 23, 2023
@nikola-jokic @ashb
removed throw and else on container action handler (actions#1873)
da277e0 
* removed throw and else on container action handler

* repaired merge resolution error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingluoHuang TingluoHuang TingluoHuang approved these changes

@fhammerl fhammerl fhammerl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikola-jokic @TingluoHuang @fhammerl