Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job hook provider now sets shell name for script handler #1826

Merged
merged 9 commits into from
Jun 8, 2022
Merged

Job hook provider now sets shell name for script handler #1826

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dd3288f
Job hook provider now sets shell name for script handler
nikola-jokic Apr 14, 2022
916360b
Merge branch 'actions:main' into nikola-jokic/bug/1825
nikola-jokic May 31, 2022
cc19f15
fixed script handler and job hook provider to work with the name with…
nikola-jokic May 31, 2022
33dbe4b
returned used import by osx
nikola-jokic May 31, 2022
8c3aae0
fixed order of imports
nikola-jokic May 31, 2022
12cfebc
added quotes around resolved script path allowing space in script path
nikola-jokic Jun 1, 2022
aeb0715
added quotes around bash and sh _defaultArguments
nikola-jokic Jun 1, 2022
6c92798
Changed double quotes to single quotes in sh -e
nikola-jokic Jun 8, 2022
64ca058
Changed double quotes to single quotes in bash
nikola-jokic Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Changed double quotes to single quotes in bash 
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
  • Loading branch information
@nikola-jokic @fhammerl
nikola-jokic and fhammerl authored Jun 8, 2022
commit 64ca0589c31d2c5aee35c80dc72da688c5bc8bbe
2 changes: 1 addition & 1 deletion src/Runner.Worker/Handlers/ScriptHandlerHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ internal class ScriptHandlerHelpers
["cmd"] = "/D /E:ON /V:OFF /S /C \"CALL \"{0}\"\"",
["pwsh"] = "-command \". '{0}'\"",
["powershell"] = "-command \". '{0}'\"",
["bash"] = "--noprofile --norc -e -o pipefail \"{0}\"",
["bash"] = "--noprofile --norc -e -o pipefail '{0}'",
["sh"] = "-e '{0}'",
["python"] = "{0}"
};
Expand Down