Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to latest versions for hashfiles #1756

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Update dependencies to latest versions for hashfiles #1756

merged 1 commit into from
Mar 18, 2022

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Mar 15, 2022 •
edited
Loading

This PR:

  • Updates the lockfile version to v2, to match node 16's default npm version
  • Updates the dependencies to their latest versions
  • Configures the linter to be less noisy and less maintenance, as a result of updating the eslint version. Hashfiles is a single file project, we are likely okay to not have heavy linting on it.

@thboop thboop requested a review from a team as a code owner March 15, 2022 20:14
thboop
thboop commented Mar 15, 2022
View reviewed changes
src/Misc/expressionFunc/hashFiles/.eslintrc.json
@@ -1,6 +1,6 @@
{
"plugins": ["jest", "@typescript-eslint"],
"extends": ["plugin:github/es6"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per docs we should pin to recommended

thboop
thboop commented Mar 15, 2022
View reviewed changes
src/Misc/expressionFunc/hashFiles/.eslintrc.json
@@ -17,13 +17,16 @@
"@typescript-eslint/no-require-imports": "error",
"@typescript-eslint/array-type": "error",
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/ban-ts-ignore": "error",
"@typescript-eslint/naming-convention": [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces

      "@typescript-eslint/camelcase": "error",
      "@typescript-eslint/class-name-casing": "error",

thboop
thboop commented Mar 15, 2022
View reviewed changes
src/Misc/expressionFunc/hashFiles/.eslintrc.json
"@typescript-eslint/unbound-method": "error"
"@typescript-eslint/unbound-method": "error",
"filenames/match-regex" : "off",
"github/no-then" : 1, // warning
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new rules introduced, we fail this one, lets warn for now and if we want to update the code later we can

thboop
thboop commented Mar 15, 2022
View reviewed changes
src/Misc/expressionFunc/hashFiles/.eslintrc.json
"@typescript-eslint/semi": ["error", "never"],
"@typescript-eslint/type-annotation-spacing": "error",
"@typescript-eslint/unbound-method": "error"
"@typescript-eslint/unbound-method": "error",
"filenames/match-regex" : "off",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this provides a regex that all filesnames must match, the project is one file, lets just turn it off.

thboop
thboop commented Mar 15, 2022
View reviewed changes
src/Misc/expressionFunc/hashFiles/.eslintrc.json
"@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}],
"@typescript-eslint/func-call-spacing": ["error", "never"],
"@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed some depreciated rules, again this is a one file project, I think we are okay without heavy linting.

"@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
"@typescript-eslint/no-object-literal-type-assertion": "error",
"@typescript-eslint/prefer-interface": "error",

thboop
thboop commented Mar 15, 2022
View reviewed changes
src/Misc/expressionFunc/hashFiles/src/hashFiles.ts
import * as crypto from 'crypto'
import * as fs from 'fs'
import * as glob from '@actions/glob'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reordered due to new rule expecting imports to be in alphabetical order

thboop
thboop commented Mar 15, 2022
View reviewed changes
src/Misc/layoutbin/hashFiles/index.js
const crypto = __importStar(__webpack_require__(417));
const fs = __importStar(__webpack_require__(747));
const glob = __importStar(__webpack_require__(281));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes besides the order of imports being moved around

@TingluoHuang TingluoHuang merged commit 48b6cd9 into main Mar 18, 2022
@TingluoHuang TingluoHuang deleted the thboop/updaterunnerdependencies branch March 18, 2022 03:21
thboop added a commit that referenced this pull request Mar 18, 2022
@thboop
Update dependencies to latest versions (#1756)
c8eede3
thboop added a commit that referenced this pull request Mar 18, 2022
@thboop
2.289.1 release (#1772)
5f72720 
* Update dependencies to latest versions (#1756)

* cleanup message displayed on job started/completed hooks (#1769)

* Revert "Added repository name and workflow file name to console output (#1761)" (#1770)

98aa9c1

* 2.289.1 release notes (#1771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingluoHuang TingluoHuang TingluoHuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thboop @TingluoHuang