-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR: Runner Job Started/Completed Hooks #1751
Conversation
Co-authored-by: Edward Thomson <ethomson@github.com>
Co-authored-by: Edward Thomson <ethomson@github.com>
Thanks @thboop, I had a chance to play with the Beta and it's mostly good for my use case - the only issue I can see so far is the precise environment variables present when the hook script runs. In my earlier PR I have a section that grabs the standard global env-vars then adds the main ones from the job's definition. This allows the workflow writer to configure the hook script slightly, e.g. via the Would it be possible to add a similar tweak here? There doesn't seem any other way of getting at them (i.e. they aren't in the event.json nor anywhere else I can think of yet)... |
I've added a very small PR needed to expose workflow env-vars to the hooks as #1849 - please have a look as it enables flexible hooks. |
This is working well for us 👍 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello? Any comments on my feedback or the PR to implement a fix @thboop ? |
Hi @thboop 👋 Reading the ADR, I noticed that you included:
I was wondering how the started/completed hooks tie with the telemetry? I am sorry if it is a silly question, but I struggle to understand it and I couldn't find any documentation about it. 😞 |
How does one do this? |
Rendered
This ADR details how we plan to support Job Started / Job Completed hooks for self hosted runner admins.