Added ability to run Dockerfile.SUFFIX ContainerAction #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
reviewed
Mar 10, 2022
fhammerl
reviewed
Mar 11, 2022
fhammerl
reviewed
Mar 11, 2022
fhammerl
reviewed
Mar 11, 2022
fhammerl
reviewed
Mar 11, 2022
fhammerl
previously approved these changes
Mar 14, 2022
fhammerl
reviewed
Mar 14, 2022
fhammerl
reviewed
Mar 14, 2022
fhammerl
reviewed
Mar 14, 2022
thboop
reviewed
Mar 21, 2022
thboop
reviewed
Mar 21, 2022
thboop
reviewed
Mar 21, 2022
|
@thboop Do you think we should wrap this one in a FF? |
fhammerl
reviewed
Apr 14, 2022
fhammerl
reviewed
Apr 14, 2022
|
|
||
| public static bool IsDockerfile(string image) | ||
| { | ||
| if (image.StartsWith("docker://", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Let's keep this if, depending on how IsDockerFile is called, we may end up checking if the image starts with docker:// multiple times.
But as a util method, I think IsDockerFile should also do the check itself so it's not reliant on being called in an if/else that has checked docker:// already.
thboop
added a commit
that referenced
this pull request
Apr 29, 2022
Merged
thboop
added a commit
that referenced
this pull request
Apr 29, 2022
cmmarslender
pushed a commit
to Chia-Network/runner
that referenced
this pull request
May 6, 2022
* Added ability to run Dockerfile.SUFFIX ContainerAction * Extracted IsDockerFile method * reformatted, moved from index to Last() * extracted IsDockerfile to DockerUtil with L0 * added check for IsDockerfile to account for docker:// * updated test to clearly show path/dockerfile:tag * fail if Data.Image is not Dockerfile or docker://[image]
cmmarslender
pushed a commit
to Chia-Network/runner
that referenced
this pull request
May 6, 2022
* Revert "Added ability to run Dockerfile.SUFFIX ContainerAction (actions#1738)" 20b7e86 * 291.1 release notes
ChristopherHX
added a commit
to ChristopherHX/runner.server
that referenced
this pull request
May 11, 2022
thboop
added a commit
that referenced
this pull request
May 22, 2022
thboop
added a commit
that referenced
this pull request
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1416
This is an enhancement to the runner allowing it to run Dockerfile.SUFFIX files, which is allowed by Docker, but doesn't work in GitHub Actions