-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SLN file and make projects build in VS #173
Conversation
- Added new ActionsRunner.sln file with all the CSPROJ's in it - Added Directory.Build.props that gets auto-included in all CSPROJ files under it - Made default runtime platforms for Windows and Linux (to be 64bit) so that you don't have to specify it in order to build
Looks like I failed on Mac build. Investigating. |
I think we should recommend using VS Code on Mac. Actually, if we're xplat equal footing, should we just slant toward VS Code? |
I think that's fine for a recommendation, but it's nice to enable VS for Windows users to work on it too. Without this change (or something like it), right now it's not possible at all. (Without this change you can only open a project, but you can't build.) |
Note that most folks work on Windows but code in VS but then build in via the cmd line to match what the CI does (dev == CI). However, I have no issue with enabling F5 VS build |
Yeah without these changes even if you do open a project you get several red squigglies because the undefined build vars lead some C# code to be excluded, leaving the project in an invalid state. With the changes in this PR, you can even compile the code. I'm not sure about F5 because I haven't gotten far enough to have an idea of what F5 should run 😄 |
Thanks for doing the legwork to add this in! The TestUtil class is used on a majority of our tests, it expects an environmental variable that does not resolve when running inside Visual Studio (the path to the Overall the pr looks great ✅ |
Indeed, I was unable to run unit tests in VS. I still think this PR is worthwhile even without being able to run tests in VS. The productivity boost of being able to build and get rich Intellisense, refactoring, and other features in VS is enormous all on its own. |
Agreed, I'll file an issue and merge this in |
Yeah I think filing an issue would be great. Perhaps a contributor can get it working! 😄 |
Filed #180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @thboop ! |
* Add SLN file and make projects build in VS - Added new ActionsRunner.sln file with all the CSPROJ's in it - Added Directory.Build.props that gets auto-included in all CSPROJ files under it - Made default runtime platforms for Windows and Linux (to be 64bit) so that you don't have to specify it in order to build * Remove extra invalid parens
Fixes #170
Fixes #172