Fix breaking change in dotnet 6 around globalization-invariant. #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
force-pushed
the
users/tihuang/fixnet6
branch
from
15a8506 to
2c1585c
Compare
cschleiden
previously approved these changes
Jan 14, 2022
TingluoHuang
force-pushed
the
users/tihuang/fixnet6
branch
from
d795260 to
1423f70
Compare
TingluoHuang
commented
Jan 14, 2022
| @@ -37,7 +37,7 @@ jobs: | |||
| devScript: ./dev.sh | |||
|
|
|||
| - runtime: win-x64 | |||
| os: windows-latest | |||
| os: windows-2019 | |||
There was a problem hiding this comment.
windows-latest is using windows-2022 which doesn't not have .net 4.5 installed, change back to windows-2019 for now
lokesh755
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround the breaking change in dotnet 6
https://docs.microsoft.com/en-us/dotnet/core/compatibility/globalization/6.0/culture-creation-invariant-mode
Fix: #1605