Set outcome/conclusion for composite action steps in steps context #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
previously approved these changes
Jan 10, 2022
fhammerl
reviewed
Jan 12, 2022
| { | ||
| step.ExecutionContext.Result = result; | ||
| SetStepsContext(step); | ||
| } |
TingluoHuang
approved these changes
Jan 12, 2022
strager
pushed a commit
to strager/github-actions-runner
that referenced
this pull request
Jan 20, 2022
…ctions#1600) * set outcome/conclusion for composite action steps in steps context * fix typo * pr fixes * fix happy case!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1578
Essentially, we need to manually set the outcome/conclusion on the steps context every time we run a composite step. A minor refactor was done in this pr to make the code more readable.