Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic telemetry #1321

Merged
merged 20 commits into from
Sep 20, 2021
Merged

Generic telemetry #1321

merged 20 commits into from
Sep 20, 2021

Conversation

fhammerl
Copy link
Contributor

@fhammerl fhammerl commented Sep 9, 2021

No description provided.

@fhammerl fhammerl requested a review from thboop September 9, 2021 20:16
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
@fhammerl fhammerl marked this pull request as ready for review September 16, 2021 13:05
@fhammerl fhammerl requested a review from a team as a code owner September 16, 2021 13:05
thboop
thboop previously approved these changes Sep 16, 2021
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Returning with a List suggests we clone it and that the
original doesn't change..
.vscode/launch.json Outdated Show resolved Hide resolved
TingluoHuang
TingluoHuang previously approved these changes Sep 17, 2021
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhammerl fhammerl merged commit 740fb43 into actions:main Sep 20, 2021
@fhammerl fhammerl deleted the generic-telemetry branch April 13, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants