-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send path when resolving actions #1250
Conversation
@@ -610,6 +610,7 @@ private async Task BuildActionContainerAsync(IExecutionContext executionContext, | |||
{ | |||
NameWithOwner = repositoryReference.Name, | |||
Ref = repositoryReference.Ref, | |||
Path = repositoryReference.Path, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider deleting the comment on this method (line 595)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline... example:
my-org/my-repo/my-folder/my-subfolder@v1
- NameWithOwner:
my-org/my-repo
- Ref:
v1
- Path
my-folder/my-subfolder
@thboop or @ericsciple do you think this would be causing our composite actions to be erroring out now? It was working yesterday just fine, and now we're seeing:
I noticed this was part of the release that came out 4 hours ago, we are using a composite action with uses clauses. The uses clause wasn't perfect but we found a workout for our flow and were relying on. Example: - name: Manually checkout all actions for easy usage
shell: bash
run: |
mkdir -p actions
git clone https://github.com/mikefarah/yq --depth 1 -b v4.11.2 actions/yq
# Additional actions followed
- name: Update chart values with built tag [helm]
# uses: mikefarah/yq@v4.11.2
uses: ./actions/yq
with:
cmd: yq ... |
@KyleJamesWalker were you using custom self hosted runnners by any chance? Composite should never have been enabled for public use on github.com. That being said, we plan to ship the feature in the very near future. |
@thboop thanks, good to know. Can't wait for this feature, it would be extremely helpful to use Github Actions in our release workflow. We're using public runners (not self-hosted), not sure if it matters any but we are also on GitHub enterprise. |
In case anyone looks at this later it is now fully working as expected: #646 (comment) |
This PR sends up the path in the resolve actions endpoint so we can properly validate policy when JIT downloading Composite Actions