Add notice annotation level and support more annotation fields #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
reviewed
Jun 28, 2021
thboop
reviewed
Jun 28, 2021
thboop
reviewed
Jun 28, 2021
thboop
reviewed
Jun 28, 2021
thboop
reviewed
Jun 30, 2021
thboop
reviewed
Jun 30, 2021
thboop
reviewed
Jun 30, 2021
thboop
reviewed
Jun 30, 2021
ericsciple
reviewed
Jul 2, 2021
ericsciple
reviewed
Jul 2, 2021
ericsciple
reviewed
Jul 2, 2021
ericsciple
reviewed
Jul 2, 2021
ericsciple
reviewed
Jul 2, 2021
ericsciple
reviewed
Jul 2, 2021
ericsciple
previously approved these changes
Jul 2, 2021
TingluoHuang
reviewed
Jul 2, 2021
TingluoHuang
reviewed
Jul 2, 2021
luketomlinson
force-pushed
the
annotations-improvements
branch
from
a0368dc to
8ba5e0e
Compare
ericsciple
reviewed
Jul 2, 2021
ericsciple
reviewed
Jul 2, 2021
ericsciple
reviewed
Jul 2, 2021
| @@ -1012,6 +1031,7 @@ public static class WellKnownTags | |||
| public static readonly string Command = "##[command]"; | |||
| public static readonly string Error = "##[error]"; | |||
| public static readonly string Warning = "##[warning]"; | |||
| public static readonly string Notice = "##[notice]"; | |||
There was a problem hiding this comment.
we might want to make the UI changes first before we start writing this.... actually i guess it doesnt matter because no one will be using this initially. So we have some time to make that change in parallel
ericsciple
previously approved these changes
Jul 2, 2021
ericsciple
approved these changes
Jul 12, 2021
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jun 17, 2024
…ns#1175) * Add Notice Command * Add Feature Flag For Enhanced Annotations * Fix tests * Add validation for columns and lines * Fix order to match service * Remove console.write * Make Validation Better * Cleanup * Handle empty/whitespace strings * Add more validation for line/column ranges * Make Validation Debug, Not Throw * Change casing to 🐫 from 🐍 * Give notice a well known tag * Cleanup * Sanitize invalid commands rather than fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
noticecommand to map to thenoticeannotation level.title,endColumn,endLine