Run config remove as user instead of root #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
reviewed
Jun 2, 2021
TingluoHuang
reviewed
Jun 2, 2021
TingluoHuang
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1079
This PR ensures that when
config.sh removeis called as part of uninstalling the runner as a service on a Linux machine, it is run as the current user instead ofroot. Calling it asrootfails because theRUNNER_ALLOW_RUNASROOTenvironment variable (which we need to set to1in order to runconfig.shas root) is usually set not set for root. The issue does a great job of explaining it.