Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on jest-each #611

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Remove dependency on jest-each #611

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9623ec3
Make `jest-each` a devDependency
ericcornelissen Jul 11, 2023
83b40fa
Remove `jest-each` and use `test-each` instead
ericcornelissen Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove jest-each and use test-each instead
  • Loading branch information
@ericcornelissen
ericcornelissen committed Jul 11, 2023
commit 83b40fa60eeeda40e16df8c38bd405baa9a70495
5 changes: 2 additions & 3 deletions __tests__/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import * as github from '@actions/github';
import * as core from '@actions/core';
import path from 'path';
import fs from 'fs';
import each from 'jest-each';

jest.mock('@actions/core');
jest.mock('@actions/github');
Expand Down Expand Up @@ -353,10 +352,10 @@ describe('run', () => {
expect(reposMock).toHaveBeenCalled();
});

each([
test.each([
[new HttpError('Error message')],
[new NotFound('Error message')]
]).test(
])(
'should warn if configuration file could not be fetched through the API, log error and fail the action',
async error => {
const configFilePath = 'non_existed_path/labeler.yml';
Expand Down
215 changes: 0 additions & 215 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"eslint-plugin-jest": "^27.2.2",
"eslint-plugin-node": "^11.1.0",
"jest": "^27.5.1",
"jest-each": "^29.6.1",
"prettier": "^2.8.8",
"ts-jest": "^27.1.3",
"typescript": "^4.9.5"
Expand Down