ci(test): run on pull request and add concurrency configuration#17
ci(test): run on pull request and add concurrency configuration#17parkerbxyz merged 7 commits intomainfrom
Conversation
This will cancel in-progress workflows if a PR is updated (i.e., a new commit is pushed) and the same workflows are triggered to run again. This reduces unnecessary compute time.
e4bdfeb to
de62487
Compare
Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
|
for reference, we are reviewing potential security vulnerabilities when using |
This reverts commit b07e73d.
.github/workflows/test.yml
Outdated
| on: | ||
| pull_request: | ||
| branches: [main] |
There was a problem hiding this comment.
I'd still keep this part
| on: | |
| pull_request: | |
| branches: [main] | |
| push: | |
| branches: | |
| - main | |
| pull_request: {} |
There was a problem hiding this comment.
I removed it because pull request checks run in the context of the merge commit, so running on push to main is redundant. Is there another use case you have in mind?
There was a problem hiding this comment.
I always thought that the push to main builds and the pull requests builds were slightly different but maybe this is no longer the case.
The other reason is if we want to add a badge showing that the CI passes, not sure if we could show a badge if we don't run test builds on the main branch?
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
demototest