Skip to content

revise ADR: convert SSH URL to HTTPS #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericsciple merged 1 commit into from
Mar 6, 2020
Merged

revise ADR: convert SSH URL to HTTPS #178

ericsciple merged 1 commit into from
Mar 6, 2020

Conversation

@ericsciple
Copy link
Contributor

@ericsciple ericsciple commented Mar 6, 2020 •
edited
Loading

This change converts SSH URLs to HTTPS when an SSH key is not supplied.

Related to #116 (comment)

@ericsciple
Copy link
Contributor Author

ericsciple commented Mar 6, 2020

@m-hilgendorf fyi

@ericsciple ericsciple mentioned this pull request Mar 6, 2020
Closed
@ericsciple
Copy link
Contributor Author

ericsciple commented Mar 6, 2020

@m-hilgendorf what about git config --global url."https://github.com/".insteadOf "git@github.com:" ?

@ericsciple ericsciple force-pushed the users/ericsciple/m167instead branch from 1044b10 to c254c34 Compare March 6, 2020 21:18
@ericsciple ericsciple mentioned this pull request Mar 6, 2020
Merged
@ericsciple ericsciple changed the title convert SSH URL to HTTPS revise ADR: convert SSH URL to HTTPS Mar 6, 2020
@ericsciple ericsciple mentioned this pull request Mar 6, 2020
Closed
@ericsciple
Copy link
Contributor Author

ericsciple commented Mar 6, 2020 •
edited
Loading

Merging. Got a review from @chrispat offline.

For any additional feedback, leave on this PR where the implementation is being worked on: #179

@ericsciple ericsciple merged commit b4626ce into master Mar 6, 2020
@ericsciple ericsciple deleted the users/ericsciple/m167instead branch March 6, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TingluoHuang TingluoHuang TingluoHuang approved these changes

@thboop thboop Awaiting requested review from thboop

@chrispat chrispat Awaiting requested review from chrispat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsciple @TingluoHuang