feat: add support for k8shook pod template #3174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Author
|
@nikola-jokic wdyt of this approach? |
Author
|
This might not be the way to go actually since you can already achieve this with setting the env var manually #1730 (comment) 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
ACTIONS_RUNNER_CONTAINER_HOOK_TEMPLATEenv var added in actions/runner-container-hooks#75 when usingcontainerMode: kubernetes.After this you can pass
podTemplateFileas a parameter in the RunnerSpec that points to a pod template file (example) that should be mounted by the user.This PR is still in draft because I'd like to collect some feedback from maintainers if they agree with the direction I've taken to implement this. Please let me know what you think!
closes #1730