Skip to content

New rule: "Color contrast for widget" #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
053359b
Draft rule
Jym77 Sep 21, 2020
d275a9f
Merge branch 'develop' into color-contrast-widget
Jym77 Nov 10, 2020
bc2d710
Typo
Jym77 Nov 11, 2020
c996057
Merge branch 'develop' into color-contrast-widget
Jym77 Nov 12, 2020
bb2684f
Create definition
Jym77 Nov 12, 2020
3a5596a
Merge branch 'develop' into color-contrast-widget
Jym77 Nov 13, 2020
be0b8ae
Polish description and applicability
Jym77 Nov 13, 2020
94a86b3
Add precision on :read-only
Jym77 Nov 13, 2020
b236846
Prepare 2 new rules
Jym77 Nov 13, 2020
80b5cde
Draft Applicability and Expectations
Jym77 Nov 13, 2020
2a77721
Merge rules and curate reference list
Jym77 Nov 13, 2020
f0d8e1c
Cleanup
Jym77 Nov 16, 2020
ac9ad62
Rename and delete files
Jym77 Nov 16, 2020
8d4e4ec
Improve handling of transient states
Jym77 Nov 16, 2020
05b9f3b
Merge branch 'develop' into color-contrast-widget
Jym77 Nov 17, 2020
4802b3a
Remove note on :read-only
Jym77 Nov 17, 2020
c910ae0
Typo
Jym77 Nov 17, 2020
033ab3e
Add Passed Examples
Jym77 Nov 18, 2020
d052523
Fix reference
Jym77 Nov 18, 2020
fb4820f
Curate references list
Jym77 Nov 18, 2020
6be8b23
Add spelling exceptions
Jym77 Nov 18, 2020
9b2bed1
Add input examples
Jym77 Nov 18, 2020
68573c4
Add Failed and Inapplicable examples
Jym77 Nov 18, 2020
fc10d00
Fix spelling
Jym77 Nov 18, 2020
ec38999
Fix examples numbering
Jym77 Nov 18, 2020
a88a9b4
Add example where text is descendant but not child of widget
Jym77 Nov 18, 2020
50d388f
Clean up
Jym77 Nov 18, 2020
131563a
Merge branch 'develop' into color-contrast-widget
Jym77 Nov 24, 2020
38bbc08
Copy assumption from disabled element
Jym77 Nov 24, 2020
8f32e71
Link both contrast rules together
Jym77 Nov 24, 2020
489b989
Add missing reference
Jym77 Nov 24, 2020
a5362b2
Merge branch 'develop' into color-contrast-widget
Jym77 Nov 27, 2020
5138e06
Explicit that applicability is about triplet
Jym77 Nov 27, 2020
948fb4f
Merge branch 'develop' into color-contrast-widget
Jym77 Nov 30, 2020
7fe815a
Improve rule description
Jym77 Dec 9, 2020
8a8421f
Merge branch 'develop' into color-contrast-widget
Jym77 Feb 18, 2021
89be892
Rework applicability according to 'states' subgroup discussion (WiP)
Jym77 Feb 18, 2021
05a556a
Add javascript to put examples in the correct state
Jym77 Mar 2, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions __tests__/spelling-ignore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@
- innerText
- isTrusted
- isComposing
- onclick

# DOM Events
- auxclick
Expand Down Expand Up @@ -251,3 +252,8 @@
# Language codes
- da
- nl

# Color names
- 0000EE
- 551A8B
- EFEFEF
3 changes: 2 additions & 1 deletion _rules/text-contrast-afw4f7.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ id: afw4f7
name: Text has minimum contrast
rule_type: atomic
description: |
This rule checks that the highest possible contrast of every text character with its background meets the minimal contrast requirement.
This rule checks that, for text which is not inside a widget, the highest possible contrast of every text character with its background meets the minimal contrast requirement.
accessibility_requirements:
wcag20:1.4.3: # Contrast (Minimum)
forConformance: true
Expand Down Expand Up @@ -61,6 +61,7 @@ This rule is designed specifically for [1.4.3 Contrast (Minimum)][sc143], which

When the text color or background color is not specified in the web page, colors from other [origins][] will be used. Testers must ensure colors are not affected by styles from a [user origin][], such as a custom style sheet. Contrast issues caused by specifying the text color but not the background or vice versa, must be tested separately from this rule.

- [Text inside widget has minimum contrast](https://act-rules.github.io/rules/nqzcj8)
- [Understanding Success Criterion 1.4.3: Contrast (Minimum)](https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html)
- [Understanding Success Criterion 1.4.6: Contrast (Enhanced)](https://www.w3.org/WAI/WCAG21/Understanding/contrast-enhanced.html)
- [G18: Ensuring that a contrast ratio of at least 4.5:1 exists between text (and images of text) and background behind the text](https://www.w3.org/WAI/WCAG21/Techniques/general/G18)
Expand Down
Loading