Skip to content

Remove false return types #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Remove false return types #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e27f4
Remove false return type
pierre-H Nov 4, 2021
db5c520
remove false return types
pierre-H Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/DependencyInjection/ACSEOTypesenseExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function load(array $configs, ContainerBuilder $container)
*
* @param ContainerBuilder $container A ContainerBuilder instance
*/
private function loadClient($config, ContainerBuilder $container): array
private function loadClient($config, ContainerBuilder $container)
{
$clientId = ('typesense.client');

Expand All @@ -80,7 +80,7 @@ private function loadClient($config, ContainerBuilder $container): array
*
* @throws \InvalidArgumentException
*/
private function loadCollections(array $collections, ContainerBuilder $container): array
private function loadCollections(array $collections, ContainerBuilder $container)
{
foreach ($collections as $name => $config) {
$collectionName = $config['collection_name'] ?? $name;
Expand Down Expand Up @@ -153,7 +153,7 @@ private function loadTransformer(ContainerBuilder $container)
/**
* Loads the configured index finders.
*/
private function loadCollectionsFinder(ContainerBuilder $container): string
private function loadCollectionsFinder(ContainerBuilder $container)
{
foreach ($this->collectionsConfig as $name => $config) {
$collectionName = $config['typesense_name'];
Expand Down