-
Notifications
You must be signed in to change notification settings - Fork 25
when using keyword search use proper queries with /q #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - Examples: "user_transactions", "revenue_2024", "customer_id" | ||
| - Will match: exact text appearances of these terms | ||
| - Structured full-text search - **always start queries with "/q "** | ||
| - Supports full boolean logic: AND (default), OR, NOT, parentheses, field searches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be good addition for simple search as well, once we establish this works as expected in majority of cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think the process o releasing it for the simple search should be? should we try updating it for the slackbot and run evals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
src/mcp_server_datahub/mcp_server.py
Outdated
| • "/q sales AND revenue" → both terms (explicit AND) | ||
| • "/q \"user data table\"" → exact phrase matching | ||
| • "/q (sales OR revenue) AND quarterly" → complex boolean combinations | ||
| • "/q name:dataset* AND platform:snowflake" → field-specific searches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does * mean here ?
Also, Its not much likely for agent to know what fields (e.g. name, platform) to search on, therefore this example can cause issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These field-specific filters have similar behavior to structured filters arg in search tool. I'm slightly concerned about behavior if both are used together ? Is one preferred over another Can you confirm this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right I should remove this example - * would match with everything starting with dataset - I'm actually not sure if this is a realistic scenario here.
No description provided.