Skip to content

Conversation

@alexsku
Copy link
Contributor

@alexsku alexsku commented Sep 9, 2025

No description provided.

@alexsku alexsku requested a review from mayurinehate September 9, 2025 04:40
- Examples: "user_transactions", "revenue_2024", "customer_id"
- Will match: exact text appearances of these terms
- Structured full-text search - **always start queries with "/q "**
- Supports full boolean logic: AND (default), OR, NOT, parentheses, field searches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be good addition for simple search as well, once we establish this works as expected in majority of cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think the process o releasing it for the simple search should be? should we try updating it for the slackbot and run evals?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

• "/q sales AND revenue" → both terms (explicit AND)
• "/q \"user data table\"" → exact phrase matching
• "/q (sales OR revenue) AND quarterly" → complex boolean combinations
• "/q name:dataset* AND platform:snowflake" → field-specific searches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does * mean here ?
Also, Its not much likely for agent to know what fields (e.g. name, platform) to search on, therefore this example can cause issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These field-specific filters have similar behavior to structured filters arg in search tool. I'm slightly concerned about behavior if both are used together ? Is one preferred over another Can you confirm this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right I should remove this example - * would match with everything starting with dataset - I'm actually not sure if this is a realistic scenario here.

@alexsku alexsku changed the title when using keyword search use proper queries with \q when using keyword search use proper queries with /q Sep 10, 2025
@alexsku alexsku merged commit ebf8900 into main Sep 12, 2025
1 check passed
@alexsku alexsku deleted the sa-semantic-PFP-1653 branch September 12, 2025 04:26
@alexsku alexsku restored the sa-semantic-PFP-1653 branch October 9, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants