Skip to content

fix: return relayerFeeDetails decimals in inputToken decimals #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2025

Conversation

mrice32
Copy link
Contributor

@mrice32 mrice32 commented Jun 1, 2025

This relates to the open question in across-protocol/frontend#1612.

We should quote all fees in terms of input tokens, not output tokens.

gsteenkamp89 and others added 4 commits May 30, 2025 23:25
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxrl pxrl merged commit 47515d8 into master Jun 2, 2025
4 checks passed
@pxrl pxrl deleted the mrice32/patch branch June 2, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants