improve(TransactionClient): Avoid using txnClient.submit() directly#3204
Open
nicholaspai wants to merge 4 commits intomasterfrom
Open
improve(TransactionClient): Avoid using txnClient.submit() directly#3204nicholaspai wants to merge 4 commits intomasterfrom
nicholaspai wants to merge 4 commits intomasterfrom
Conversation
The TransactionClient.submit() is not designed for general use because it can return undefined rather than throw if a txn succeeds which is usually not the caller's intuition. `submitTransaction` should be used instead.
nicholaspai
requested review from
bmzig,
dohaki,
mrice32 and
pxrl
as code owners
nicholaspai
commented
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TransactionClient.submit() is not designed for general use because it can return undefined rather than throw if a txn succeeds which is usually not the caller's intuition.
submitTransactionshould be used instead.