improve(package): Skip ts-node for most scripts #2878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ts-node is slow to run. These scripts should be available in dist, so just run the native Javascript instances to save time.
pxrl
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
Comment on lines
88
to
89
| "update-addresses": "yarn ts-node ./scripts/fetch-addresses.ts", | ||
| "update-inventory-config": "yarn ts-node ./scripts/fetchInventoryConfig.ts", |
Contributor
There was a problem hiding this comment.
OOC, why not move these 2 as well?
Collaborator
Author
There was a problem hiding this comment.
I wanted to, but when I tested it I realised that we run these before build, so we can't rely on the .js outputs to be available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts-node is slow to run. These scripts should be available in dist, so just run the native Javascript instances to save time.