feat: Support Circle bridged & native USDC on zkSync #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxrl
commented
Mar 27, 2025
pxrl
commented
Mar 27, 2025
pxrl
commented
Mar 27, 2025
nicholaspai
reviewed
Mar 27, 2025
nicholaspai
reviewed
Mar 27, 2025
pxrl
changed the title
pxrl
commented
Mar 27, 2025
pxrl
commented
Mar 27, 2025
pxrl
commented
Mar 27, 2025
* improve: support upgradeable USDC in zkstack adapters Signed-off-by: bennett <bennett@umaproject.org> * update deploy scripts Signed-off-by: bennett <bennett@umaproject.org> * conform to CCTPAdapterInterface Signed-off-by: bennett <bennett@umaproject.org> --------- Signed-off-by: bennett <bennett@umaproject.org>
nicholaspai
previously approved these changes
Apr 2, 2025
mrice32
reviewed
Apr 2, 2025
Co-authored-by: Matt Rice <matthewcrice32@gmail.com>
mrice32
reviewed
Apr 2, 2025
mrice32
reviewed
Apr 2, 2025
Co-authored-by: Matt Rice <matthewcrice32@gmail.com>
…ntracts into pxrl/lensUSDC
mrice32
reviewed
Apr 2, 2025
mrice32
previously approved these changes
Apr 2, 2025
nicholaspai
changed the base branch from
master
to
march-evm-audit-universal-adapter
bmzig
approved these changes
Apr 3, 2025
pxrl
commented
Apr 3, 2025
Contributor
Author
pxrl
left a comment
pxrl
left a comment
There was a problem hiding this comment.
I can't approve because I authored the PR, but this LGTM.
nicholaspai
changed the base branch from
march-evm-audit-universal-adapter
to
audit-zkstack-usdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lens uses Circle's Bridged (upgradable) USDC standard and requires a custom bridge for it. On mainnet, the chain adapter contract needs a modified workflow to make deposits. On the L2 it's as simple as depositing via a different contract address, albeit with the same contract interface as the standard ERC20 bridge.
As part of this change, both ends are updated for eventual CCTP compatibility. This introduces some configuration nuance to the constructor arguments of both contracts:
usdcAddress = 0x0=> USDC tokens are routed via the standard ERC20 bridge (current required for zkSync USDC.e).usdcAddress != 0x0ANDcctpTokenMessenger != 0x0=> USDC tokens are routed via Circle's CCTP bridges.usdcAddress != 0x0ANDzkUSDCBridge != 0x0=> USDC tokens are routed via the custom bridge for Circle Bridged (upgradable) USDC.A simple check on the various constructor arguments imposed during deployment, but it's highly recommended to manually verify the configurations post-deployment.
Implementation according to the Matter Labs guidance at https://github.com/matter-labs/usdc-bridge
This is immediately for Lens but is generalised to apply to any zkSync-stack deployment.